Differences
This shows you the differences between two versions of the page.
| Next revision | Previous revision | ||
|
ust:meeting_minutes_march_7_2018 [2018/03/07 19:37] gli created |
ust:meeting_minutes_march_7_2018 [2021/09/19 21:59] (current) |
||
|---|---|---|---|
| Line 8: | Line 8: | ||
| * Akira Vernon | * Akira Vernon | ||
| - | Continued working on React Exercise Task 4 on changing display based on button press. | + | Continued working on React Exercise Task 4 on changing display based on button press. Discussed code reviews, pull request, and creating issues for Dashboard team on GitHub. |
| ---- | ---- | ||
| Line 16: | Line 16: | ||
| * Create the same app using Semantic React components | * Create the same app using Semantic React components | ||
| * The picture being displayed corresponds to which button was pressed | * The picture being displayed corresponds to which button was pressed | ||
| + | |||
| + | Code Reviews | ||
| + | * Master branch locked until code reviewers gives as okay | ||
| + | * Components should be able to accept and manipulate data | ||
| + | * Pull requests ~150 lines of code | ||
| + | * Always add Kevin to code reviews | ||
| + | * Once approved by all reviewers, merging will be available | ||
| + | |||
| + | Pull Request | ||
| + | * git clone <repository https> : clones repository to own developing space | ||
| + | * git pull --rebase : checks recent commits for any conflicts in update | ||
| + | * git checkout -b <branch number> : checks out branch for changes (specifically for new branches) | ||
| + | * Make sure to be in the master branch | ||
| + | |||
| + | Creating Issues | ||
| + | * Make an issue for own page | ||
| + | * For Weatherboxes page | ||
| + | * Weatherbox option | ||
| + | * Issue would be adding button to switch state of weatherbox | ||
| + | * For components, naming convention would be SCEL in front of component | ||
| ---- | ---- | ||
| === Tasks === | === Tasks === | ||
| - | - Kevin: Update Design Documents. | + | - Kevin: Documentation and mock data for Dashboard |
| - | - Gordon: Task 4: Changing Display; update Design Documents. | + | - Gordon: Task 4: Changing Display, update Design Documents, and create and work on issue for Weatherboxes page. |
| - | - Kyle, Jon, & Akira: Task 4: Changing Display. | + | - Kyle, Jon, & Akira: Create and work on an issue for Graph Generator page. |
| - | Full team: Task 4: Changing Display. | + | Full team: Create and work on issues for individual Dashboard components. |